Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Add TF based TBAnalyticsReceiver #3035

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[2.5] Add TF based TBAnalyticsReceiver #3035

merged 2 commits into from
Oct 14, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Oct 14, 2024 •
edited
Loading

Add TF based TBAnalyticsReceiver

Description

  • Add TF based TBAnalyticsReceiver

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh force-pushed the remove_tb_receiver_from_tf_job_api_25 branch from f027eff to 49194b0 Compare October 14, 2024 05:53
@YuanTingHsieh YuanTingHsieh changed the title [2.5] Remove TBReceiver from tf job api and fix doc errors [2.5] Remove TBReceiver from tf job api Oct 14, 2024
@YuanTingHsieh YuanTingHsieh force-pushed the remove_tb_receiver_from_tf_job_api_25 branch from 5710fb7 to e1832a5 Compare October 14, 2024 22:36
@YuanTingHsieh YuanTingHsieh changed the title [2.5] Remove TBReceiver from tf job api [2.5] Add TF based TBAnalyticsReceiver Oct 14, 2024
@YuanTingHsieh YuanTingHsieh added the enhancement New feature or request label Oct 14, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

IsaacYangSLA
IsaacYangSLA approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this new class. LGTM.

@IsaacYangSLA IsaacYangSLA enabled auto-merge (squash) October 14, 2024 22:54
@IsaacYangSLA IsaacYangSLA merged commit 426f252 into NVIDIA:2.5 Oct 14, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the remove_tb_receiver_from_tf_job_api_25 branch October 14, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacYangSLA IsaacYangSLA IsaacYangSLA approved these changes

@SYangster SYangster Awaiting requested review from SYangster

@holgerroth holgerroth Awaiting requested review from holgerroth

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@nvidianz nvidianz Awaiting requested review from nvidianz

@yhwen yhwen Awaiting requested review from yhwen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @IsaacYangSLA